Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages in aggregation modale #732

Conversation

Pascal-Delange
Copy link
Contributor

@Pascal-Delange Pascal-Delange commented Mar 5, 2025

Prerequisites

See checkmarble/marble-backend#889 for error codes definition.

Content

Display a "pretty" error message below the field selector in the aggregation modale when the state of the node is not completely set, or inconsistent choices are made.

Screenshots

No field chosen:
Capture d’écran 2025-03-05 à 23 35 35

Field chosen has a type that is not compatible with this aggregation function:
Capture d’écran 2025-03-05 à 23 35 45

@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-793-in-the-aggregate-construction-modale-if-we-start-to-edit-the branch from ae1a5c8 to 6507935 Compare March 5, 2025 22:56
rollback: disabled was an error
@Pascal-Delange Pascal-Delange force-pushed the pascal/mar-793-in-the-aggregate-construction-modale-if-we-start-to-edit-the branch from 6507935 to 18a5477 Compare March 5, 2025 22:58
@Pascal-Delange Pascal-Delange marked this pull request as ready for review March 5, 2025 22:58
Copy link
Contributor

@ChibiBlasphem ChibiBlasphem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pascal-Delange Pascal-Delange merged commit 3410108 into main Mar 6, 2025
3 checks passed
@Pascal-Delange Pascal-Delange deleted the pascal/mar-793-in-the-aggregate-construction-modale-if-we-start-to-edit-the branch March 6, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants