Update IntranetIP widget to copy URL to clipboard #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds a copy-to-clipboard feature for the intranet IP address widget in the dashboard. When users tap the intranet IP, the full URL (including port) is copied to the clipboard and a confirmation message is displayed. The implementation includes:
- Conversion of the IntranetIP widget from StatelessWidget to ConsumerWidget to access provider state
- Addition of clipboard copy functionality that formats the IP and port as a URL
- UI enhancement with a copy icon displayed when an IP address is available
- Localization support for the confirmation message across all four supported languages (English, Japanese, Russian, and Simplified Chinese)
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/views/dashboard/widgets/intranet_ip.dart |
Converted to ConsumerWidget, added clipboard copy functionality with URL formatting, added copy icon to UI |
lib/l10n/l10n.dart |
Added getter for the new "copied" localization string |
lib/l10n/intl/messages_en.dart |
Added English translation for "copied" |
lib/l10n/intl/messages_ja.dart |
Added Japanese translation for "copied" |
lib/l10n/intl/messages_ru.dart |
Added Russian translation for "copied" |
lib/l10n/intl/messages_zh_CN.dart |
Added Simplified Chinese translation for "copied" |
arb/intl_en.arb |
Added English source translation for "copied" |
arb/intl_ja.arb |
Added Japanese source translation for "copied" |
arb/intl_ru.arb |
Added Russian source translation for "copied" |
arb/intl_zh_CN.arb |
Added Simplified Chinese source translation for "copied" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a "Copy to clipboard" feature for the intranet IP address in the dashboard widget. When the user taps the intranet IP, the full URL is copied to the clipboard, and a confirmation message is shown in the user's selected language. The necessary localization strings and UI changes have been implemented to support this feature.
Feature: Intranet IP Copy-to-Clipboard
copiedlocalization string. (lib/views/dashboard/widgets/intranet_ip.dart) [1] [2] [3]Localization Updates
copiedstring to all supported languages in the ARB files: English, Japanese, Russian, and Simplified Chinese. (arb/intl_en.arb,arb/intl_ja.arb,arb/intl_ru.arb,arb/intl_zh_CN.arb) [1] [2] [3] [4]copiedstring for each language. (lib/l10n/intl/messages_en.dart,lib/l10n/intl/messages_ja.dart,lib/l10n/intl/messages_ru.dart,lib/l10n/intl/messages_zh_CN.dart) [1] [2] [3] [4]copiedin the main localization class. (lib/l10n/l10n.dart)This pull request has been only tested on amd64 Windows platform now. Please test on other platforms