address copy-on-write-related warnings #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas is moving to a copy-on-write model. From their guide: > CoW means that any DataFrame or Series derived from another in any way always behaves as a copy. As a consequence, we can only change the values of an object through modifying the object itself. Thus, `new_teams["trb"].fillna(0, inplace=True)` would not work with CoW (trb would be filled with zeroes only in a copy, not in the original `new_teams` dataframe). This can be addressed by using a slightly different syntax for in-place updates. Migration guide: https://pandas.pydata.org/docs/dev/user_guide/copy_on_write.html#copy-on-write-migration-guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas is moving to a copy-on-write model.
From their guide:
Thus,
new_teams["trb"].fillna(0, inplace=True)would not work with CoW (trb would be filled with zeroes only in a copy, not in the originalnew_teamsdataframe).This can be addressed by using a slightly different syntax for in-place updates.
Migration guide: https://pandas.pydata.org/docs/dev/user_guide/copy_on_write.html#copy-on-write-migration-guide