Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RotateContext handle command tests #252

Merged
merged 4 commits into from
Nov 28, 2023
Merged

RotateContext handle command tests #252

merged 4 commits into from
Nov 28, 2023

Conversation

hpya93
Copy link
Contributor

@hpya93 hpya93 commented Nov 2, 2023 •
edited
Loading

Hi @jhand2
Added tests for RotateContextHandle command

  • Added a test to check and report invalid handle with a test handle (moved to negativeCases.go, taken care in PR 255, as a common negative case test)

The following are part of this PR:

  • RotateHandle in default context
  • RotateHandle in non-default context
  • RotateHandle in with TARGET_DEFAULT flag

@hpya93 hpya93 closed this Nov 21, 2023
@hpya93 hpya93 force-pushed the rotatehandle_support branch from 2ff7f90 to e364da7 Compare November 21, 2023 18:53
@hpya93
Copy link
Contributor Author

hpya93 commented Nov 21, 2023

Synced branch

@hpya93 hpya93 reopened this Nov 21, 2023
@hpya93
Copy link
Contributor Author

hpya93 commented Nov 22, 2023

@jhand2 conflicts are resolved for this PR, could this be reviewed and merged?

jhand2
jhand2 reviewed Nov 23, 2023
View reviewed changes
@jhand2 jhand2 merged commit ac339f6 into chipsalliance:main Nov 28, 2023
@hpya93 hpya93 deleted the rotatehandle_support branch November 29, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhand2 jhand2 jhand2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hpya93 @jhand2