Implement full DPE validation #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests in progress. Please suggest other validations to check if you have any ideas. |
sree-revoori1
force-pushed
the
validation
branch
2 times, most recently
from
e8f2660 to
4503517
Compare
|
Tests are done and PR is ready for review. |
sree-revoori1
force-pushed
the
validation
branch
from
4503517 to
4dd5b43
Compare
zhalvorsen
reviewed
Dec 12, 2023
jhand2
reviewed
Dec 12, 2023
DPE validation does two things: 1. Checks for illegal state in DPE 2. Checks that the DPE context tree is well-formed 2 was done in a previous commit, but this commit improves upon that implementation in a few ways: 1. Previously we were returning a bool from the context tree validation function. Now we return an error code so the caller knows exactly what is wrong with the shape of the DPE context tree 2. We weren't considering simulation contexts before. Simulation contexts forming a different connected component is not an error.
sree-revoori1
force-pushed
the
validation
branch
from
4dd5b43 to
25deec4
Compare
zhalvorsen
approved these changes
Dec 12, 2023
jhand2
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPE validation does two things:
2 was done in a previous commit, but this commit improves upon that implementation in a few ways:
fixes #279
fixes #284