Exchange CDI for CDI handle via DPE::Crypto trait #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
commented
Jan 16, 2025
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
6 times, most recently
from
cab66ad to
fd8ae95
Compare
clundin25
commented
Jan 22, 2025
jhand2
reviewed
Jan 22, 2025
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
2 times, most recently
from
bdf97b4 to
5a633c9
Compare
jhand2
reviewed
Jan 23, 2025
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
from
5a633c9 to
c78f0c2
Compare
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
2 times, most recently
from
b78c812 to
4a114b3
Compare
jhand2
reviewed
Jan 24, 2025
crypto/src/openssl.rs
Outdated
| @@ -41,23 +44,37 @@ impl Hasher for OpensslHasher { | |||
| } | |||
| } | |||
|
|
|||
| // Currently only supports one CDI handle but in the future we may want to support multiple. | |||
| const MAX_CDI_HANDLES: usize = 1; | |||
| type ExportedCdiHandle = [u8; MAX_EXPORTED_CDI_SIZE]; | |||
There was a problem hiding this comment.
Should this be defined in lib.rs?
There was a problem hiding this comment.
Updated. I kept MAX_CDI_HANDLES private since it's implementation dependent but I'm happy to make it public.
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
from
4a114b3 to
47af71f
Compare
jhand2
reviewed
Jan 27, 2025
clundin25
force-pushed
the
cdi-handle-exchange-pr
branch
from
47af71f to
3297d02
Compare
clundin25
merged commit 2b7de2d
into
chipsalliance:feature/gh-issue-caliptra-sw-1807
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.