Add DPE Platform function to retrieve Ueid #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to populate the Ueid extension in the x509 certificate created by DeriveContext when export-cdi is used.
clundin25
force-pushed
the
platform-ueid
branch
from
0d71122 to
818aa73
Compare
jhand2
reviewed
Jan 27, 2025
| @@ -23,6 +23,8 @@ pub const MAX_KEY_IDENTIFIER_SIZE: usize = 20; | |||
| pub const MAX_VALIDITY_SIZE: usize = 24; | |||
| pub const MAX_OTHER_NAME_SIZE: usize = 128; | |||
|
|
|||
| pub type Ueid = [u8; 17]; | |||
There was a problem hiding this comment.
I wonder if we should return an ArrayVec here to allow the UEID to be variable length from the platform
There was a problem hiding this comment.
I'll follow up with you offline and merge this.
jhand2
approved these changes
Jan 27, 2025
clundin25
merged commit c145caf
into
chipsalliance:feature/gh-issue-caliptra-sw-1807
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used to populate the Ueid extension in the x509 certificate created by DeriveContext when export-cdi is used.