Auto-initialize DPE with the RT Journey PCR #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sree-revoori1
requested review from
jhand2,
fdamato,
rusty1968 and
bluegate010
as code owners
sree-revoori1
force-pushed
the
auto_init
branch
3 times, most recently
from
5dee000 to
220218b
Compare
sree-revoori1
force-pushed
the
auto_init
branch
from
220218b to
d4be7a7
Compare
jhand2
reviewed
Dec 8, 2023
sree-revoori1
force-pushed
the
auto_init
branch
from
d4be7a7 to
f6f3353
Compare
jhand2
reviewed
Dec 8, 2023
sree-revoori1
force-pushed
the
auto_init
branch
from
f6f3353 to
63c02c0
Compare
jhand2
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a bug in RT where Drivers::get_dpe_root_context_idx returns the incorrect DPE context index. This function searches for the context whose parent is 0xFF, which indicates that that context is the root. However, DPE is auto-initialized and then DeriveChild is called in order to measure the RT journey PCR into a child context. This means the root context does not contain the RT journey PCR which is incorrect.
With the change in chipsalliance/caliptra-dpe#278, we are able to auto-initialize DPE with a measurement. Using that, we now auto-initialize DPE with the RT journey PCR so that we don't have an extraneous default measurement in DPE.
This PR also updates tagging behavior to allow GET_TAGGED_TCI on retired contexts and disallow TAG_TCI on retired contexts. The test has been updated accordingly.
This PR also adds a test that checks that measurements are stored in DPE when STASH_MEASUREMENT is called.
Fixes #1118
Fixes #1169