Make RT depend on caliptra-cfi and update DPE version #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sree-revoori1
requested review from
jhand2,
fdamato,
rusty1968,
bluegate010,
mhatrevi,
ajisaxena,
vsonims,
korran and
JohnTraverAmd
as code owners
sree-revoori1
force-pushed
the
dpe_cfi
branch
2 times, most recently
from
ae00a45 to
ddc789b
Compare
korran
reviewed
Feb 12, 2024
sree-revoori1
force-pushed
the
dpe_cfi
branch
3 times, most recently
from
40eeb40 to
157a34d
Compare
jhand2
reviewed
Feb 13, 2024
There was a problem hiding this comment.
LGTM, but will need a submodule update when chipsalliance/caliptra-dpe#310 is merged. I assume the current submodule import isn't a commit in main.
sree-revoori1
force-pushed
the
dpe_cfi
branch
2 times, most recently
from
55bdd50 to
e7c7ff3
Compare
mhatrevi
previously approved these changes
Feb 13, 2024
sree-revoori1
force-pushed
the
dpe_cfi
branch
from
e7c7ff3 to
d16eda0
Compare
jhand2
approved these changes
Feb 14, 2024
mhatrevi
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we forked caliptra-sw's cfi crate into a new repo, caliptra-cfi, to be able to add CFI in DPE. In this PR, we make RT use caliptra-cfi instead of caliptra-sw's cfi so that we can update DPE to the latest version containing CFI instrumentation. To do this correctly without modifying the ROM binary, we make drivers depend on caliptra-cfi only if the runtime flag is enabled.
The plan is to make caliptra-cfi a submodule and replace the cfi crate with caliptra-cfi everywhere. We will do this for ROM 1.01.
The RT binary size delta is + 7800 due to adding CFI to DPE.