Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLDSA KAT tests #1943

Open
wants to merge 6 commits into
base: main-2.x
Choose a base branch
from
Open

MLDSA KAT tests #1943

wants to merge 6 commits into from
+990 −21

Conversation

mtimkovich
Copy link

Write tests for the 3 ways to set MldsaSeed.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 5, 2025 •
edited
Loading

CLA Not Signed

@mhatrevi mhatrevi force-pushed the vmhatre/mldsa-driver-update branch from 4b4c2dd to f5c5316 Compare February 5, 2025 02:12
@mhatrevi mhatrevi added the Caliptra v2.0 Items to be considered for v2.0 Release label Feb 5, 2025
@mtimkovich mtimkovich force-pushed the mtimkovich/mldsa-driver-update branch 2 times, most recently from 4416c0d to 2eb1065 Compare February 5, 2025 20:06
@mtimkovich mtimkovich changed the base branch from vmhatre/mldsa-driver-update to main-2.x February 5, 2025 20:06
@mtimkovich mtimkovich changed the title Implement MLDSA sign without keygen. MLDSA KAT tests Feb 7, 2025
@mtimkovich
Copy link
Author

#1922

mhatrevi
mhatrevi reviewed Feb 7, 2025
View reviewed changes
kat/src/mldsa87_kat.rs Outdated Show resolved Hide resolved
mhatrevi
mhatrevi reviewed Feb 7, 2025
View reviewed changes
kat/src/mldsa87_kat.rs Outdated Show resolved Hide resolved
mhatrevi
mhatrevi requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@mhatrevi mhatrevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the feedback.

@mtimkovich mtimkovich force-pushed the mtimkovich/mldsa-driver-update branch from dcff4b5 to 44589f7 Compare February 7, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhatrevi mhatrevi mhatrevi requested changes

@FerralCoder FerralCoder Awaiting requested review from FerralCoder

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

@bluegate010 bluegate010 Awaiting requested review from bluegate010 bluegate010 is a code owner

@swenson swenson Awaiting requested review from swenson swenson is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@korran korran Awaiting requested review from korran korran is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

@jhand2 jhand2 Awaiting requested review from jhand2 jhand2 is a code owner

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtimkovich @mhatrevi