sw-emulator: MLKEM KV dword order fix#3443
Draft
swenson wants to merge 1 commit intochipsalliance:mainfrom
Draft
sw-emulator: MLKEM KV dword order fix#3443swenson wants to merge 1 commit intochipsalliance:mainfrom
swenson wants to merge 1 commit intochipsalliance:mainfrom
Conversation
In an upcoming RTL release, the MLKEM (ABR) key vault integration will fix a dword ordering issue, where dwords ordering was reversed with respect to the other cryptographic hardware (e.g., how MLDSA behaved). I tested this against the upcoming RTL on the FPGA to confirm this behavior and modified the test firmware. This will fail on FPGA until the bitstreams are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an upcoming RTL release, the MLKEM (ABR) key vault integration will fix a dword ordering issue, where dwords ordering was reversed with respect to the other cryptographic hardware (e.g., how MLDSA behaved).
I tested this against the upcoming RTL on the FPGA to confirm this behavior and modified the test firmware.
This will fail on FPGA until the bitstreams are updated.