Improvements and fixes for VeeR-EL2 testing #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the way that the `c` extension is disabled, i.e. removed from the arch ISA string. Without this change, for GCC versions where Zicsr and Zifencei constitute separate extensions, the following ISA string: rv32imc_zicsr_zifencei_zba_zbb_zbc_zbs Would be changed to (note incorrect `_zisr` vs correct `_zicsr`): rv32im_zisr_zifenei_zba_zbb_zb_zbs Instead of the expected: rv32im_zicsr_zifencei_zba_zbb_zbc_zbs Signed-off-by: Filip Kokosinski <[email protected]>
Signed-off-by: Filip Kokosinski <[email protected]>
Signed-off-by: Mateusz Karlic <[email protected]>
Signed-off-by: Mateusz Karlic <[email protected]>
Signed-off-by: Mateusz Karlic <[email protected]>
|
Hi @kgugala, can you provided some detail on what this PR accomplishes? |
Signed-off-by: Wiktoria Kuna <[email protected]>
Signed-off-by: Wiktoria Kuna <[email protected]>
Some of the 'I' ext instructions were once moved to separate Zicsr and Zifencei extensions. For newer toolchains the 'Z' extensions need to be explicitly requested in '-march'. Signed-off-by: Wiktoria Kuna <[email protected]>
Signed-off-by: Wiktoria Kuna <[email protected]>
workflows: Update upload-artifacts to v4
@MikeOpenHWGroup This PR collects a few other PRs fixing a few small bugs and adds some useful features. We've updated the description of the PR with links to other PRs and some more info |
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
cextension run: fix disabling thecextension #988