Skip to content

Allow configuration of gateway URL for legacy API#98

Merged
chloerei merged 1 commit intochloerei:masterfrom
kfit-dev:chore/change-alipay-domain-name
Jan 22, 2026
Merged

Allow configuration of gateway URL for legacy API#98
chloerei merged 1 commit intochloerei:masterfrom
kfit-dev:chore/change-alipay-domain-name

Conversation

@zhenghui97
Copy link
Contributor

@zhenghui97 zhenghui97 commented Jan 19, 2026

  • Update to allow the configuration of gateway url for legacy API according to region

@zhenghui97
Copy link
Contributor Author

@chloerei could you help to review & merge this PR? Thanks in advance.

@zhenghui97 zhenghui97 force-pushed the chore/change-alipay-domain-name branch from 806b110 to d47e239 Compare January 20, 2026 05:00
@chloerei
Copy link
Owner

  • Please move the QR code related code to a new pull request.
  • I've fixed some issues with the test environment and the new Ruby version (e.g., minitest-mock), you can rebase.
  • I prefer to name it Alipay.gateway_url and set the default value Alipay.gateway_url ||= 'https://mapi.alipay.com/gateway.do' at the bottom of lib/alipay.rb. This gateway is still used in mainland China. I don't want to break the existing application after updating the gem.
  • Test cases continue to use the mapi domain and do not need to be changed.

@zhenghui97 zhenghui97 force-pushed the chore/change-alipay-domain-name branch 2 times, most recently from 0e6a7f1 to 7ac1170 Compare January 22, 2026 02:32
@zhenghui97 zhenghui97 force-pushed the chore/change-alipay-domain-name branch from 7ac1170 to 1480cea Compare January 22, 2026 02:35
@zhenghui97 zhenghui97 changed the title Configure gateway URL for legacy API & integrate Create Preorder QR Code Allow configuration of gateway URL for legacy API Jan 22, 2026
@chloerei chloerei merged commit b2cd7d8 into chloerei:master Jan 22, 2026
4 checks passed
@chloerei
Copy link
Owner

I will add path /gateway.do in gateway_url.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants