Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNG file icon. Find libraries one level deeper from wildcard #26

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

FoamyGuy
Copy link
Collaborator

Resolves: #25

Adds .png to the types that will get the image file icon.

Also checks for imports one level deeper inside of wildcard imports of files that are included in learn project code.

This allows Karel the Robot project to correctly show the required libraries inside of lib/ even though they come from karel.circuitpythonkarel.* instead of code.py directly.

With this change:
image

With the current version:
image

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FoamyGuy FoamyGuy merged commit ac0eda7 into circuitpython:main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG files get the wrong icon
2 participants