Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the list of shown filetypes. always show settings.toml #32

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

FoamyGuy
Copy link
Collaborator

@FoamyGuy FoamyGuy commented Feb 26, 2025

Resolves: #31
Updates the list of shown filetypes to match all of the ones in the Icon map.

Also remove the restriction from showing settings.toml. With this change it will always be shown instead of only when certain libraries are present.

I found that an empty settings.toml is created by default when Circuitpython is first loaded on a device, and when storage.erase_filesystem() is run so it's likely the user will see it on their drive no matter what libraries are in use.

Removing the condition means we don't need to keep track of that list of libraries any more either 🎉

Copy link

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@FoamyGuy FoamyGuy merged commit 87088f6 into circuitpython:main Feb 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

png and jpg files are not included in drive screenshots
2 participants