Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjustments to action td on tables #3075

Open
6 tasks done
asaki222 opened this issue Nov 13, 2024 · 7 comments · May be fixed by #3444
Open
6 tasks done

Adjustments to action td on tables #3075

asaki222 opened this issue Nov 13, 2024 · 7 comments · May be fixed by #3444
Assignees
@CocoByte
Labels
carryover Carryover from a previous sprint dev issue is for the dev team Feature: 🏢 Org Model
Milestone
Org Model m4 - Do...

Comments

@asaki222
Copy link
Contributor

asaki222 commented Nov 13, 2024 •
edited by CocoByte
Loading

Issue description

The tables across org and non-org model need to be adjusted so they don't stretch so wide. Currently, we're seeing a lot of extra white space between table items, this is leading to a hard to scan table and a visually unpleasing interface. The space between the action td(Edit/View/Manage) and the kebab increases when the user stretches the screen; however, we want that width to stay the same no matter how they adjust their screen to maintain consistency.

Acceptance criteria

  • Changes below apply to tables Domains, Domain requests, Members, and non-org tables
  • Reduce max width of org/non-org tables so it does not stretch as wide as it does currently (check with designer to confirm width)
  • change alignment of page content so that table is center aligned
  • On all Action Tds: The more options "kebab" button and action td(Edit/Manage/View) should have a fixed space between them to prevent the space from increasing.
  • Max width of the action tds is set to 80px
  • Padding between action td (Edit/Manage/View) and the kebab is set to 4px.

Additional context

Slack Thread on the topic of adjusting the action td
Slack thread on discussing the width of tables

Links to other issues

No response
@asaki222 asaki222 added dev issue is for the dev team Feature: 🏢 Org Model labels Nov 13, 2024
@katypies katypies moved this from 👶 New to 🍦 Backlog in .gov Product Board Nov 18, 2024
@abroddrick
Copy link
Contributor

Dm'd for more info on the ACs and mild edits, once resolved this will be marked as ready.

@abroddrick abroddrick moved this from 🍦 Backlog to 🎯 Ready in .gov Product Board Nov 22, 2024
@gabydisarli
Copy link
Contributor

@abroddrick I updated this ticket to add some changes to the table widths.

@gabydisarli
Copy link
Contributor

@abroddrick when this comes up for design review, can we make sure me and @kristinacyin are added as design reviewers? thanks!

@gabydisarli gabydisarli changed the title Adjustments to action td in domain requests table Adjustments to action td on tables Jan 9, 2025
@Matt-Spence Matt-Spence self-assigned this Jan 27, 2025
@abroddrick
Copy link
Contributor

Feedback from @rachidatecs
AC 2: This will look bad at the min end of the desktop query
AC 4, 5 and 6: I think this is no longer relevant after Nikki merged the 2 columns?

@gabydisarli or @kristinacyin any thoughts on the feeback from rachid mentioned above? Throwing refinement on it to make sure these are answered.

@Matt-Spence Matt-Spence removed their assignment Jan 27, 2025
@gabydisarli
Copy link
Contributor

@abroddrick I adjusted AC 2 to be a little less prescriptive and more clearly communicate what the desire behavior is. From my understanding, AC 4, 5, and 6 are still relevant.

The Action column is one on Domains but not Members.

Image
Image

@gabydisarli
Copy link
Contributor

And the Action tds still need that max width set. If it's easier, you can adjust the ticket to just say to work with me on the adjustments needed.

@CocoByte CocoByte self-assigned this Jan 27, 2025
@CocoByte CocoByte moved this from 🎯 Ready to 🔖 Planned in .gov Product Board Jan 28, 2025
@CocoByte CocoByte moved this from 🔖 Planned to 🏗 In progress in .gov Product Board Jan 29, 2025
@katypies
Copy link
Contributor

katypies commented Feb 3, 2025

Removed refinement - @CocoByte and @gabydisarli are coordinating on outstanding questions.

@CocoByte CocoByte moved this from 🏗 In progress to 👀 In review in .gov Product Board Feb 3, 2025
@dave-kennedy-ecs dave-kennedy-ecs linked a pull request Feb 6, 2025 that will close this issue
Open
32 tasks
@PaulKuykendall PaulKuykendall added the carryover Carryover from a previous sprint label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CocoByte CocoByte

Labels
carryover Carryover from a previous sprint dev issue is for the dev team Feature: 🏢 Org Model
Projects
.gov Product Board
Status: 👀 In review
Milestone
Org Model m4 - Domain Requests
Development

Successfully merging a pull request may close this issue.

#3075 Adjustments to action td on tables - [NL] cisagov/manage.get.gov
8 participants
@katypies @Matt-Spence @CocoByte @PaulKuykendall @gabydisarli @abroddrick @asaki222 @zandercymatics