#3075 Adjustments to action td on tables - [NL] #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…80px. Add Action column updates to Members table.
CocoByte
requested review from
therealslimhsiehdy,
Matt-Spence,
dave-kennedy-ecs,
erinysong,
asaki222,
zandercymatics,
jaxonsilva24,
SamiyahKey and
a team
|
🥳 Successfully deployed to developer sandbox nl. |
|
🥳 Successfully deployed to developer sandbox nl. |
Comment on lines
-51
to
-62
| let existingExtraActionsHeader = document.querySelector('.extra-actions-header'); | ||
|
|
||
| if (hasEditPermission && !existingExtraActionsHeader) { | ||
| const extraActionsHeader = document.createElement('th'); | ||
| extraActionsHeader.setAttribute('id', 'extra-actions'); | ||
| extraActionsHeader.setAttribute('role', 'columnheader'); | ||
| extraActionsHeader.setAttribute('class', 'extra-actions-header width-5'); | ||
| extraActionsHeader.innerHTML = ` | ||
| <span class="usa-sr-only">Extra Actions</span>`; | ||
| let tableHeaderRow = this.tableWrapper.querySelector('thead tr'); | ||
| tableHeaderRow.appendChild(extraActionsHeader); | ||
| } |
There was a problem hiding this comment.
good cleanup, thanks
dave-kennedy-ecs
approved these changes
Feb 6, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
🥳 Successfully deployed to developer sandbox nl. |
|
The changes look good to me, definitely an improvement! @gabydisarli Sorry if I'm being annoying, but I think I'm still confused on why the right margin is larger than the left margin? Like if you compare the red and blue lines in the screenshot, the red line is longer.
|
|
🥳 Successfully deployed to developer sandbox nl. |
gabo0oo
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #3075
Changes
Context for reviewers
The ACs for this ticket were slightly modified during talks with design. Modifications are as follows;
Setup
Code Review Verification Steps
Verify the following for all org/non-org tables
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots