#2719 - delete and recreate database workflow #3453

asaki222 · 2025-02-04T15:44:51Z

#2719

Changes

Added yaml file that deletes and recreates databases for non production sandboxes.get
Added documentation for new yaml file.

Context for reviewers

Setup

Unfortunately, it can't be tested on main until it is merged. I do have a forked repo where you can test it, if you would like.

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Update documentation in READMEs and/or onboarding guide

Ensured code standards are met (Original Developer)

If any updated dependencies on Pipfile, also update dependencies in requirements.txt.
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

Tag @dotgov-designers in this PR's Reviewers for design review. If code is not user-facing, delete design reviewer checklist
Verify new pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Verified code meets all checks above. Address any checks that are not satisfied
Reviewed this code and left comments. Indicate if comments must be addressed before code is merged
Checked that all code is adequately covered by tests
Verify migrations are valid and do not conflict with existing migrations

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
(Rarely needed) Tested as both an analyst and applicant user

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior. Comment any found issues or broken flows.
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

References

Code review best practices

Screenshots

… rh/2719-action-non-production-sandbox

github-actions · 2025-02-04T19:39:27Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-02-04T20:34:05Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-02-05T15:13:31Z

🥳 Successfully deployed to developer sandbox rh.

Matt-Spence

Looks pretty good, one issue that I think needs to be addressed. Also, could you go in and clean up the spacing and add spaces before the comment strings? ("# comment" instead of "#comment"

Matt-Spence · 2025-02-06T17:00:09Z

.github/workflows/delete-and-recreate-db.yaml

+      CF_PASSWORD: CF_${{ github.event.inputs.environment }}_PASSWORD
+      DESTINATION_ENVIRONMENT: ${{ github.event.inputs.environment}}
+    steps:
+    - name: Dekete and Recreate Database


Suggested change

- name: Dekete and Recreate Database

- name: Delete and Recreate Database

Small typo

Matt-Spence · 2025-02-06T17:13:00Z

.github/workflows/delete-and-recreate-db.yaml

+         until cf service getgov-$DESTINATION_ENVIRONMENT-database | grep -q 'The service instance status is succeeded'
+         do
+         echo "Database not up yet, waiting..."
+         sleep 30
+        done


This should have a timeout. Right now, if the service creation fails for any reason this could end up as an infinite loop.

github-actions · 2025-02-06T18:42:35Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-02-06T18:55:23Z

🥳 Successfully deployed to developer sandbox rh.

github-actions · 2025-02-06T18:56:50Z

🥳 Successfully deployed to developer sandbox rh.

Matt-Spence

LGTM

github-actions · 2025-02-06T19:38:54Z

🥳 Successfully deployed to developer sandbox rh.

asaki222 added 4 commits February 3, 2025 16:03

yaml file and docs

fa27f26

fixed text

9b4ae79

updated script

394fc26

fixed typos

62e7b09

asaki222 requested a review from abroddrick as a code owner February 4, 2025 15:44

asaki222 added 3 commits February 4, 2025 10:46

changed the file path

5bd8ec6

Merge branch 'main' of https://github.com/cisagov/manage.get.gov into…

89ab3e8

… rh/2719-action-non-production-sandbox

removed script link

1a3e83b

asaki222 changed the title ~~Rh/2719 action non production sandbox~~ #2719 - delete and recreate database workflow Feb 4, 2025

updated to main

9e038d1

Matt-Spence self-assigned this Feb 6, 2025

Matt-Spence reviewed Feb 6, 2025

View reviewed changes

asaki222 added 3 commits February 6, 2025 12:36

changes

1bba542

updates

a2151f4

trying again

75ae3d3

asaki222 added 2 commits February 6, 2025 13:50

increased timeout

6408058

increased timeout and fixed spacing

8c35346

Matt-Spence approved these changes Feb 6, 2025

View reviewed changes

missed a comment space

5247bc3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2719 - delete and recreate database workflow #3453

#2719 - delete and recreate database workflow #3453

asaki222 commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 5, 2025

Matt-Spence left a comment

Matt-Spence Feb 6, 2025

Matt-Spence Feb 6, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

Matt-Spence left a comment

github-actions bot commented Feb 6, 2025

	- name: Dekete and Recreate Database
	- name: Delete and Recreate Database

#2719 - delete and recreate database workflow #3453

Are you sure you want to change the base?

#2719 - delete and recreate database workflow #3453

Conversation

asaki222 commented Feb 4, 2025

Changes

Context for reviewers

Setup

Code Review Verification Steps

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

References

Screenshots

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 4, 2025

github-actions bot commented Feb 5, 2025

Matt-Spence left a comment

Choose a reason for hiding this comment

Matt-Spence Feb 6, 2025

Choose a reason for hiding this comment

Matt-Spence Feb 6, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

Matt-Spence left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2025