-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3463: Add breadcrumb to analytics page - [LITTERBOX] #3478
Conversation
Not needed for this PR - we don't know yet quite what we want to do
🥳 Successfully deployed to developer sandbox za. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% endcomment %} | ||
<div class="breadcrumbs"> | ||
<a href="{% url "admin:index" %}">{% trans "Home" %}</a> | ||
› |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What is the reasoning behind using the text of ›
(which translates to "›") versus ">"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its what the original django template uses! If I just used ">" it wouldn't be consistent with the other pages.
As for the why, I am not sure why the django team is using that specifically (but maybe its for visual distinction?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment for screenshots -- I just forgot to hit approve!
🥳 Successfully deployed to developer sandbox za. |
Ticket
Resolves #3463
Changes
Context for reviewers
During accessibility testing, it was noted that the side nav bar would "disappear" at smaller resolutions. It was eventually determined that navigation still was accessible, but it was hidden behind confusing UI because our breadcrumb was not properly configured.
This PR tightens that up. Our next eventual step might be to properly integrate the analytics page into Django admin (as it currently is not), but for the scope and overarching goal of this ticket that is not done here.
Setup
To test this, go to django admin and click "Dashboard" under the analytics app. Note the breadcrumb.
Try going into mobile view, you should be able to navigate back to home using the breadcrumb and the .gov button.
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Validated user-facing changes as a developer
Note: Multiple code reviewers can share the checklists above, a second reviewer should not make a duplicate checklist. All checks should be checked before approving, even those labeled N/A.
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
References
Screenshots