Makercli testing #275
Closed
Makercli testing #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
007harshmahajan
changed the title
mojoX911
requested changes
Nov 6, 2024
Comment on lines
+85
to
+93
| fn execute_directory_cli(&self, args: &[&str]) -> Result<String, Box<dyn std::error::Error>> { | ||
| let output = Command::new("cargo") | ||
| .args(&["run", "--bin", "directory-cli", "--"]) | ||
| .args(args) | ||
| .output()?; | ||
|
|
||
| Ok(String::from_utf8(output.stdout)?.trim().to_string()) | ||
| } | ||
| } |
- write addresses to files for each POST request from Maker - introduce different types for directory server errors. - nit: fix typo in `addres_rpc`
Signed-off-by: wthrajat <[email protected]>
Signed-off-by: wthrajat <[email protected]>
This includes: - using `makerd` rpc socket instead of `directoryd`. - give correct `RpcMsgResp` as per the rpc call. - fixes some typos and increase UX.
This includes: - use better delay logic while waiting for any funding tx to be in mempool and confirming the fidelity tx. - use `get_next_external_address` for recieving any funds instead of `fidelity` address. - sync the wallet inside the `create_fidelity` api and save in-memory data while shutting down the maker server. - show balance in `BTC` as bitcoin-cli wallet defaults to `btc` amounts.
- Fund maker while running maker server instead of shutting down the server in case of `Insufficient Funds` and again restarting it after giving enough amount.
|
Override by #311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very rough, need to have very large refactoring