pretty print offer-data #422
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 70.43% 70.40% -0.04%
==========================================
Files 34 34
Lines 4245 4247 +2
==========================================
Hits 2990 2990
- Misses 1255 1257 +2 ☔ View full report in Codecov by Sentry. |
| self.minimum_locktime, | ||
| self.max_size, | ||
| self.min_size, | ||
| self.tweakable_point, |
There was a problem hiding this comment.
We need to add the tor address instead.
| self.max_size, | ||
| self.min_size, | ||
| self.tweakable_point, | ||
| self.fidelity |
There was a problem hiding this comment.
fidelity itself is a pretty big structure, we cannot directly print it. We just need the fidelity_bond value. And to calculate that we need access to the bitcoin RPC.
So this cannot be implemented directly with Display trait. Instead make a dedicated function at taker::api.rs, named display_fidelity, and use the taker::wallet::rpc to calculate the bond value. There is a caluclate_bond_value API on FidelityBond that you can directly use.
This pr tries to solve issue #413 ,Please have a look on it, I have implemented display trait, should I go with Serde? Suggest the changes I will work upon them