Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(citizen-server-impl): always give HTTP headers #3128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MoskalykA
Copy link
Contributor

Goal of this PR

When PerformHttpRequest encounters an http code other than 200, it receives the headers

How is this PR achieving the goal

Replace an empty list with the headers variable

This PR applies to the following area(s)

Server

Successfully tested on

Game builds: Not applicable

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

https://forum.cfx.re/t/missing-response-headers-in-performhttprequest-for-non-200-status-codes/

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant