Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scene-recognition point-wise evaluation #55

Merged
merged 5 commits into from
Jul 8, 2024
Merged

scene-recognition point-wise evaluation #55

merged 5 commits into from
Jul 8, 2024

Conversation

jyoune
Copy link
Contributor

@jyoune jyoune commented Jul 1, 2024

Removed unnecessary files from sr-eval branch, added proper preds directory, and made some small changes to both whole-repo README and sr-eval/README. Addresses comments left in sr-eval pull request (53)

@jyoune jyoune requested a review from keighrim July 1, 2024 21:12
@keighrim keighrim mentioned this pull request Jul 2, 2024
Copy link
Member

@keighrim keighrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, could you add a report document based on this template. The file naming convention isn't fully fixed yet, but let's use

report-YYYYMMDD-<PREDS_DIR_NAME>.md

jyoune added 2 commits July 5, 2024 14:17
… requirements.txt, and removed goldretriever.py, all addressing requested changes in PR
…, also made outputs cleaner and in their own sub-directory.
@jyoune jyoune requested a review from keighrim July 5, 2024 18:32
@jyoune
Copy link
Contributor Author

jyoune commented Jul 5, 2024

These latest commits should address the requested changes, along with some improvements to organization

@keighrim keighrim changed the title Sr eval final scene-recognition point-wise evaluation Jul 5, 2024
…ration-27-d.md

changed to permalinks
@keighrim keighrim merged commit c511e4a into main Jul 8, 2024
@keighrim keighrim deleted the sr-eval-final branch July 8, 2024 17:10
@keighrim
Copy link
Member

keighrim commented Jul 9, 2024

For reference, this PR was a fix for #49 and a partial fix for #43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants