App Submitted - easyocr-wrapper.v1.0 #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keighrim
requested changes
Jan 23, 2024
|
|
||
|
|
||
| #### Inputs | ||
| * [http://mmif.clams.ai/vocabulary/VideoDocument/v1](http://mmif.clams.ai/vocabulary/VideoDocument/v1) (required) |
There was a problem hiding this comment.
Looks like the app also requires TimeFrame annotations as well (https://github.com/clamsproject/app-easyocr-wrapper/blob/v1.0/app.py#L41) . Metadata is missing.
| |pretty|The JSON body of the HTTP response will be re-formatted with 2-space indentation|boolean|N|false|**_`false`_**, `true`| | ||
|
|
||
|
|
||
| #### Outputs |
There was a problem hiding this comment.
Looking at the app.py code, and it also says the view from this app also contains Relation (https://github.com/clamsproject/app-easyocr-wrapper/blob/v1.0/app.py#L37), but never adds such annotations. Could you review the view.new_contain part of the app.py?
|
closing this for re-submission |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(no connected issue)
This PR registers the app easyocr-wrapper.v1.0 from https://github.com/clamsproject/app-easyocr-wrapper/tree/v1.0. Carefully review the metadata before merging. If something is wrong with the metadata, please close the PR and let the app developer know.
(submitted by @snewman-aa)