Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding utils for handling VideoDocument #233

Merged
merged 16 commits into from
Jul 19, 2023
Merged

adding utils for handling VideoDocument #233

merged 16 commits into from
Jul 19, 2023

Conversation

keighrim
Copy link
Member

fixes #221
fixes #229

This PR adds extra dependency installation in the build process, and based on those CV-related dependencies, add mmif.utils package with helpers for handing annotations on time-based media (mostly VideoDocument).

@keighrim keighrim marked this pull request as ready for review July 19, 2023 04:35
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #233 (8c17fa1) into develop (89bbd15) will decrease coverage by 2.21%.
The diff coverage is 68.51%.

@@             Coverage Diff             @@
##           develop     #233      +/-   ##
===========================================
- Coverage    94.30%   92.09%   -2.21%     
===========================================
  Files            6        8       +2     
  Lines          930     1025      +95     
===========================================
+ Hits           877      944      +67     
- Misses          53       81      +28     
Flag Coverage Δ
unittests 92.09% <68.51%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmif/utils/video_document_helper.py 66.33% <66.33%> (ø)
mmif/serialize/annotation.py 92.80% <100.00%> (+<0.01%) ⬆️
mmif/utils/__init__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@keighrim keighrim merged commit 9a83945 into develop Jul 19, 2023
@keighrim keighrim deleted the 229-cv-helpers branch July 19, 2023 04:42
@keighrim keighrim mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants