Conversation
Co-authored-by: Copilot <copilot@github.com>
Some clarification in spec doc
`appProfiling` as official view metadata key
added `appTag` field to view metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds two optional (backward-compatible) view-metadata fields (
appTags,appProfiling) and clarifies spec prose aroundparameters.Additions
appTags: optional view-metadata field holding a list of short string labels that classify what kind of work the view represents. Advisory only, no controlled vocabulary is mandated at this point (addedappTagsfield to view metadata #253 also see CLAMS "app patterns" or "task vocabulary" clams-python#262).appProfiling: optional view-metadata dictionary holding runtime measurements collected while producing the view.clams-pythonhas emitted this field since added runningtime and hwinfo recorder (as universal params) clams-python#237 (refined in added VRAM profile for CUDA device in view metadata clams-python#258); this release makes it official. The only sub-field defined by the spec isrunningTime; others (e.g. CPU, GPU info, memory footprint) are at the producing app's discretion (appProfilingas official view metadata key #254).Changes
parametersdict semantics and corrected the view-properties count in the spec prose; reworded the metadata-properties section around annotation IDs (Some clarification in spec doc #252).