Fix higher order blackboxes not propagating usage metadata#3148
Open
Fix higher order blackboxes not propagating usage metadata#3148
Conversation
rowanG077
force-pushed
the
3147-verilog-blackbox-for-iteratei-uses-wire-for-sequential-assignments
branch
from
755916f to
c52cf26
Compare
rowanG077
changed the title
Member
Author
|
Sad to say neither verilator or yosys catch this as a warning. And just text based checks really sucks because on my machine this text based check passes but I guess with different GHC/Clash combinations the exact ordering can be different. |
rowanG077
force-pushed
the
3147-verilog-blackbox-for-iteratei-uses-wire-for-sequential-assignments
branch
2 times, most recently
from
10982ba to
53fee98
Compare
rowanG077
force-pushed
the
3147-verilog-blackbox-for-iteratei-uses-wire-for-sequential-assignments
branch
from
53fee98 to
507b203
Compare
rowanG077
changed the title
rowanG077
force-pushed
the
3147-verilog-blackbox-for-iteratei-uses-wire-for-sequential-assignments
branch
from
507b203 to
661931c
Compare
Member
Author
|
The given reproducer in the issue actually wasn't a reproducer, but with explicit clocks it does reproduce. For the verification all sequential assignments to identifiers are gathered and it's checked the identifiers are declared as |
martijnbastiaan
approved these changes
Feb 11, 2026
Member
martijnbastiaan
left a comment
martijnbastiaan
left a comment
There was a problem hiding this comment.
I'm not 100% sure on the fix, but the tests look like they actually test something sensible to ✔️
Member
Author
|
Let's wait for the grandmaster @christiaanb to see if he thinks this is the proper fix. |
rowanG077
requested review from
christiaanb
and removed request for
lmbollen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.