Add more simulation controls to ExpectOptions
#156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbollen
force-pushed
the
lucas/improve-expect-options
branch
5 times, most recently
from
eee5090 to
483313b
Compare
martijnbastiaan
requested changes
Jul 2, 2025
clash-protocols/tests/Tests/Protocols/PacketStream/PacketFifo.hs
Outdated
Show resolved
Hide resolved
lmbollen
changed the title
ExpectOptionsExpectOptions
lmbollen
force-pushed
the
lucas/improve-expect-options
branch
from
483313b to
50b3afd
Compare
Previous implementation of `propWithModel` could generate 100 stalls for every allowed sample in `eoSampleMax` which could lead to unreasonably long simulations. This change introduces `eoStallsMax` and `eoConsecutiveStalls` that offer more control over the stalling behavior of `propWithModel`. Furthermore it makes setting `eoStopAfterEmpty` optional and adds a default derivation method.
lmbollen
force-pushed
the
lucas/improve-expect-options
branch
from
50b3afd to
5c40aae
Compare
martijnbastiaan
approved these changes
Jul 2, 2025
jaschutte
pushed a commit
to jaschutte/flakey-clash-protocols
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI fails stochastically on some tests due to conservative settings of
eStopAfterEmpty.This pull request adjusts the implementation of
propWithModelto give the user more control over the stalling generation. Furthermore it makes settingeoStopAfterEmptyoptional and adds a default derivation method.This default is conservative, some circuits might rely on the last transaction for it to start producing data so we assume maximum stalling. Do note that this new configuration severely lowers the default number of stall moments to 10. Problems that arise only when there are more than 10 individual stall moments will never be caught be the default configuration.
However, I don't expect this to be the case for 99% of the circuits, making it a sensible default.