Split DfConv instance for AXI4 channels
#161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…ssInfo` internally Previously the constructor bit of `M2S_WriteAddress` was also present internally, while it was identical to the `Maybe` value of `Df`. Using `Axi4WriteAddressInfo` instead saves 1 bit.
hiddemoll
force-pushed
the
hidde/split-axi-dfconv
branch
from
9f16772 to
91ee280
Compare
hiddemoll
force-pushed
the
hidde/split-axi-dfconv
branch
from
91ee280 to
f66cd43
Compare
Contributor
Author
|
I'm closing this PR and created an issue for future reference, see #163. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now two
DfConvinstances, one for the combined write channels and one for the combined read channels. What we'd rather have is aDfConvinstance for each channel. For each channel we should addDfConv,Simulate,DrivableandTest. This should make it easier to write AXI4 circuits and test them.TODO:
DfConvinstance for Write and Read channelWriteAddressWriteDataWriteResponseReadAddressReadDataDfConvfor each AXI4 channel (probably withidWithModelDf)WriteAddressWriteDataWriteResponseReadAddressReadData