Support Nix build for all Clash-GHC supported versions #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaschutte
force-pushed
the
nix-multi-ghc-support
branch
from
230711a to
f788434
Compare
diegodiv
reviewed
Aug 8, 2025
jaschutte
force-pushed
the
nix-multi-ghc-support
branch
from
f788434 to
b055cc9
Compare
Contributor
Author
|
Me and Diego discussed this PR some more in PMs. I am not aware of a way to resolve this within Nix, it is caused by Cabal prioritizing sources mentioned in I think it's best to have this behavior documented in the README and that's the best we can do, opinions on this @DigitalBrains1 ? |
jaschutte
force-pushed
the
nix-multi-ghc-support
branch
from
b055cc9 to
5d87598
Compare
Member
|
I am not aware of a better way to do this than "If you use Nix, remove |
jaschutte
force-pushed
the
nix-multi-ghc-support
branch
from
5d87598 to
1acc9e5
Compare
Contributor
Author
I've added it as a comment above the devShell itself in the flake. I wanted to originally add it to the README but I couldn't find an appropriate place to mention it. (The entire README feels more a guide on Df than a README for the repository in my opinion anyways) |
See: https://github.com/clash-lang/clash-cores/blob/main/clash-cores.cabal#L85 The same issue applies for clash-protocols
jaschutte
force-pushed
the
nix-multi-ghc-support
branch
from
1acc9e5 to
8b076fc
Compare
diegodiv
approved these changes
Aug 12, 2025
diegodiv
left a comment
diegodiv
left a comment
There was a problem hiding this comment.
It's basically good for me, and I left two suggestions for improvement.
jaschutte
force-pushed
the
nix-multi-ghc-support
branch
5 times, most recently
from
5c9d2c6 to
5de4704
Compare
Instead of only supporting the 'default' ghc version of clash-compiler, it now supports the same set of ghc versions as clash-compiler itself. More about why this is a problem can be found at (clash-lang/clash-compiler#2987) It also addresses the Cabal-Nix bug where Setup.hs improperly gets flags set. This problem also persists in clash-cores and has been worked around with (https://github.com/clash-lang/clash-cores/blob/main/clash-cores.cabal#L85).
jaschutte
force-pushed
the
nix-multi-ghc-support
branch
from
5de4704 to
e08ca82
Compare
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 21, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 22, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 22, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 27, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 27, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 27, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 28, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 29, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in: clash-lang/clash-protocols#164
jaschutte
added a commit
to clash-lang/clash-cores
that referenced
this pull request
Aug 29, 2025
Restructures everything Nix related to be more similar to how clash-protocols and clash-circuits have it setup. This means it now uses flakes, removes all the 'old style' Nix files and applies the GHC patches mentioned in clash-cores.cabal prior to this commit. All of this is very similar to how it is done in: clash-lang/clash-protocols#164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only supporting the 'default' ghc version of clash-compiler,
it now supports the same set of ghc versions as clash-compiler itself.
More about why this is a problem can be found at (clash-lang/clash-compiler#2987).
It also addresses the Cabal-Nix bug where Setup.hs improperly gets flags set. This problem also persists in clash-cores and has been worked around with (https://github.com/clash-lang/clash-cores/blob/main/clash-cores.cabal#L85). However considering it's an issue with Nix specifically, I feel it's more appropriate to patch it within the flake itself.