Disable tests for flake package #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanG077
force-pushed
the
flake-disable-tests
branch
from
4eb7c82 to
bceab03
Compare
jaschutte
approved these changes
Sep 2, 2025
it like that and we have a test flake. Which means users can get spurious build errors. See: #131
rowanG077
force-pushed
the
flake-disable-tests
branch
from
bceab03 to
29ff1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #131 our tests sporadically fail. We should ideally fix this but for now it's better to let our uses still get the package without spurious build failures.