Add automatic package pushing to binary caches #167
Conversation
jaschutte
force-pushed
the
ci-auto-upload
branch
from
0a99231 to
f3e0d2e
Compare
jaschutte
force-pushed
the
ci-auto-upload
branch
3 times, most recently
from
0ea0d03 to
d97a9ef
Compare
|
Could this get a 2nd look? I have updated this to implement the feedback that was mentioned in the clash-cores PR. |
jaschutte
force-pushed
the
ci-auto-upload
branch
from
d97a9ef to
49ae403
Compare
.github/workflows/ci.yml
Outdated
| fourmolu: | ||
| runs-on: ubuntu-latest | ||
| runs-on: self-hosted |
There was a problem hiding this comment.
Could you explain why we move supposedly tiny jobs such as fourmolu and linting to self-hosted runners?
(I did assume that moving the stack job was a deliberate choice to either increase speed or decrease runner minutes spent on our monthly usage quota).
There was a problem hiding this comment.
The others were moved to the local CI, so I didn't pay it too much attention. I can revert it if that's preferred.
There was a problem hiding this comment.
When our machines are doing a lot of CI, small jobs should generally run faster on GitHub-hosted runners than self-hosted runners because their fleet of runners is so much larger than ours. So I would like to see all small jobs remain on GitHub-hosted runners.
I'm not sure what you mean by "the others were moved to local CI", which others do you mean specifically and which PR did that?
Adds Nix caching as a CI step. It caches both the developer shell and Nix package. Overall very similar to clash-lang/clash-cores#48
jaschutte
force-pushed
the
ci-auto-upload
branch
from
49ae403 to
16c7791
Compare
| runs-on: ubuntu-22.04 | ||
| runs-on: self-hosted |
There was a problem hiding this comment.
This is another tiny job I think is best run on GitHub-hosted runners.
Makes CI automatically push packages to the binary cache for commits on the main branch. This way the caches always contain the latest versions. It also updates the documentation to include a small chapter about how to include Cachix to use the cache. Both the developer shell and the package itself get cached.
Practically a 1:1 copy of clash-lang/clash-cores#48