Open
Conversation
rowanG077
force-pushed
the
clog_commute_const
branch
from
1482f78 to
7f26b14
Compare
martijnbastiaan
approved these changes
Jul 11, 2022
Member
martijnbastiaan
left a comment
martijnbastiaan
left a comment
There was a problem hiding this comment.
Core logic LGTM, mostly style+doc changes requested.
rowanG077
changed the title
*Log b (n * b^f) to *Log b n * f*Log b (n * b^f) to *Log b n + f
rowanG077
force-pushed
the
clog_commute_const
branch
from
7f26b14 to
27d5dd4
Compare
Member
Author
|
I fixed the requested change and also bumped the version to |
rowanG077
force-pushed
the
clog_commute_const
branch
3 times, most recently
from
3a7a1ba to
f36f13f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
I added the same reduction for
FLogandCLog. Code is not super pretty since there are quite a bit of conversions between different type representations.