Skip to content

Conversation

ulya-tkch
Copy link
Contributor

@ulya-tkch ulya-tkch commented Sep 18, 2025

Key Info

  • Note: typeignore is added to the types because this is experimental we do not want to require importing any strands code into the real package

  • Implementation plan: link

  • Priority:

What changed?

This adds an experimental folder with a strands integration

What do you want the reviewer(s) to focus on?


Checklist

  • Did you link the GitHub issue?
  • Did you follow deployment steps or bump the version if needed?
  • Did you add/update tests?
  • What QA did you do?
    • Tested...

@ulya-tkch ulya-tkch requested a review from jwmueller September 18, 2025 23:55
@@ -0,0 +1,9 @@
# Requirements for cleanlab_codex strands integration
# Core dependencies
cleanlab-tlm>=1.1.14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need it for form_response_string_chat_completions_api like functions from cleanlab_tlm.utils.chat

@@ -0,0 +1,9 @@
# Requirements for cleanlab_codex strands integration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explicitly confirm that you've tested using the cleanlab-codex in an environment where strands and these other optional dependencies are NOT installed, and the rest of codex package still works as usual? I.e. that these dependencies truly are optional

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in an env without strands + with strands. We are not adding any dependencies to the cleanlab package here, just in a requirements.txt for users to manually install

# Requirements for cleanlab_codex strands integration
# Core dependencies
cleanlab-tlm>=1.1.14
openai
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanlab.validate() expects messages in OpenAI format, to pass typechecker I had to typecast which means we now require types during runtime here.

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had small suggestions and things to confirm.

I'm inclined not to invest other engineers' time on this experimental module. But if there's anything you are concerned about in terms of affecting the overall Codex experience for developers who are not using this strands module, then please do ask engineer to review that aspect.

@ulya-tkch
Copy link
Contributor Author

I fixed the typecasting issue. This should be good to go.

@ulya-tkch ulya-tkch merged commit 2898a18 into main Sep 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants