markup_parser: skip parsing HTML content when it is empty #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue
This PR resolves the following CI error.
```
Error:
FullTextSearch::BatchRunnerSynchronizeTest#test_archived_changeset:
RuntimeError: input string cannot be empty
plugins/full_text_search/lib/full_text_search/markup_parser.rb:20:in `parse'
plugins/full_text_search/lib/full_text_search/issue_mapper.rb:25:in `upsert_fts_target'
plugins/full_text_search/lib/full_text_search/batch_runner.rb:129:in `block (2 levels) in synchronize_fts_targets_internal'
plugins/full_text_search/lib/full_text_search/batch_runner.rb:335:in `each'
plugins/full_text_search/lib/full_text_search/batch_runner.rb:335:in `each'
plugins/full_text_search/lib/full_text_search/batch_runner.rb:335:in `iterate'
plugins/full_text_search/lib/full_text_search/batch_runner.rb:121:in `block in synchronize_fts_targets_internal'
plugins/full_text_search/lib/full_text_search/resolver.rb:43:in `each'
plugins/full_text_search/lib/full_text_search/resolver.rb:43:in `each'
plugins/full_text_search/lib/full_text_search/batch_runner.rb:116:in `synchronize_fts_targets_internal'
plugins/full_text_search/lib/full_text_search/batch_runner.rb:12:in `synchronize'
plugins/full_text_search/test/unit/full_text_search/batch_runner_synchronize_test.rb:34:in `setup'
bin/rails test plugins/full_text_search/test/unit/full_text_search/batch_runner_synchronize_test.rb:219
```
Cause
The error occurs because Nokogiri's behavior for handling an empty
string changed in version 1.17.0.
- Before 1.17.0: `Nokogiri::HTML::SAX::Parser#parse` returned
`nil` when passed an empty string.
- After 1.17.0: `Nokogiri::HTML::SAX::Parser#parse` raises a
`RuntimeError` when passed an empty string.
Refer to the following Nokogiri commit for details:
sparklemotion/nokogiri@35596e7
Solution
Skip parsing the HTML content when it is empty by adding a presence
check.
kou
reviewed
Dec 17, 2024
| if html.presence | ||
| parser = Nokogiri::HTML::SAX::Parser.new(document) | ||
| parser.parse(html) | ||
| end |
There was a problem hiding this comment.
Can we use an early return instead?
def parse
html = ...
return ["", []] unless html.present?
document = Document.new
...
end
kou
reviewed
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR resolves the following CI error.
Cause
The error occurs because Nokogiri's behavior for handling an empty string changed in version 1.17.0.
Nokogiri::HTML::SAX::Parser#parsereturnednilwhen passed an empty string.Nokogiri::HTML::SAX::Parser#parseraises aRuntimeErrorwhen passed an empty string.Refer to the following Nokogiri commit for details: sparklemotion/nokogiri@35596e7
Solution
Skip parsing the HTML content when it is empty by adding a presence check.