Add FullTextSearch::IssueAnySearchable module for multi-field AND searches
#164
Conversation
…earches GitHub: clear-codeGH-163 This commit introduces the `FullTextSearch::IssueAnySearchable` module to the `IssueQuery` class. The module is designed to support AND-based searches across multiple fields. This initial implementation only sets up the module and its interface without implementing the actual search logic. At the following PRs, we will implemente the search logic and adding relevant tests.
otegami
force-pushed
the
add-issue-any-searchable
branch
2 times, most recently
from
70264f9 to
21aedb8
Compare
otegami
force-pushed
the
add-issue-any-searchable
branch
from
6ebccfe to
2dc7600
Compare
init.rb
Outdated
| @@ -91,6 +91,11 @@ class << Setting | |||
| FullTextSearch::TagType | |||
| FullTextSearch::Type | |||
|
|
|||
| if Gem::Version.new(Redmine::VERSION) > Gem::Version.new("5.1") | |||
There was a problem hiding this comment.
I added this condition because the original Issue#sql_for_any_searchable_fieldis called and causes the error by the time we implement the IssueAnySearchable#sql_for_any_searchable_field.
There was a problem hiding this comment.
Can we use feature based check instead of version based check?
BTW, should we use >= here?
There was a problem hiding this comment.
fix: 9cfbe32 Thanks, is this implementation satisfied with your feature based check?
|
@kou |
| } | ||
| } | ||
| ) | ||
| searched_issues = Issue.where(query.statement).order(:id) |
There was a problem hiding this comment.
It seems that issues page use IssueQuery#issues not Issue.where(query.statement): https://github.com/redmine/redmine/blob/09167d0b3238a4a7e27fded6a4111fe39f1bf22f/app/controllers/issues_controller.rb#L62
Should we use the same API?
There was a problem hiding this comment.
fix: 08ef3cc I think using the same API is better. I fixed it.
|
@kou |
GitHub: GH-163
This commit introduces the
FullTextSearch::IssueAnySearchablemodule to theIssueQueryclass.The module is designed to support AND-based searches across multiple fields.
This initial implementation only sets up the module and its interface without implementing the actual search logic.
At the following PRs, we will implement the search logic and adding relevant tests.