This repository has been archived by the owner on May 6, 2020. It is now read-only.
Install doc fixes #740
Merged
Install doc fixes #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the installation docs should tell the user to use the `busybox` docker image rather than the `fedora` one since the former is tiny and much quicker to download. Partially fixes clearcontainers#739. Signed-off-by: James O. D. Hunt <[email protected]>
The here document specified in the Ubuntu installation guide syntax was incorrect as it had a space between "<<" and "EOT". Partially fixes clearcontainers#739. Signed-off-by: James O. D. Hunt <[email protected]>
For parity with the other installation guides, ensure that all commands specified in the Ubuntu installation guide can be run non-interactively. Fixes clearcontainers#739. Signed-off-by: James O. D. Hunt <[email protected]>
|
kubernetes qa-failed 👎 |
Added a missing indent for the last step for the Fedora and Ubuntu installation documents. Signed-off-by: James O. D. Hunt <[email protected]>
|
Hi @iphutch - please could you take a look? |
|
kubernetes qa-failed 👎 |
iphutch
suggested changes
Oct 19, 2017
docs/fedora-installation-guide.md
Outdated
| @@ -52,8 +52,8 @@ $ sudo systemctl start cc-proxy.socket | |||
|
|
|||
| 5. Run Clear Containers 3.0. | |||
|
|
|||
| You are now ready to run Clear Containers 3.0. For example: | |||
| You are now ready to run Clear Containers 3.0. For example: | |||
There was a problem hiding this comment.
Are we using "For example" here because there are multiple ways to run Clear Containers 3.0? If not, let's remove or replace "For example:"
There was a problem hiding this comment.
Agreed - branch updated.
docs/ubuntu-installation-guide.md
Outdated
| @@ -52,8 +52,8 @@ $ sudo systemctl start cc-proxy.socket | |||
|
|
|||
| 5. Run Clear Containers 3.0. | |||
|
|
|||
| You are now ready to run Clear Containers 3.0. For example: | |||
| You are now ready to run Clear Containers 3.0. For example: | |||
Remove "for example" from the Ubuntu and Fedora installation docs as it's redundant. Signed-off-by: James O. D. Hunt <[email protected]>
|
kubernetes qa-passed 👍 |
|
Doc-only change (which reminds me, clearcontainers/jenkins#11), so merging. |
mcastelino
pushed a commit
to mcastelino/runtime
that referenced
this pull request
Dec 6, 2018
…to-collect-script scripts: Add throttler details to collect script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.