lib: Ensure pwd_buf is always freed in write_ssh_keys

Prior to this change, a NULL pw_dir would result in pwd_buf being leaked after write_ssh_keys is called. Granted, it's a minor leak, and only potential, but should still be fixed regardless. Signed-off-by: Ikey Doherty <[email protected]>
clearlinux · Jul 27, 2016 · 574c759 · 574c759
1 parent bc5f756
commit 574c759
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/lib.c b/src/lib.c
@@ -250,7 +250,7 @@ bool write_ssh_keys(const GString* data, const gchar* username) {
 	GString* ssh_keys = NULL;
 	struct passwd pwd;
 	struct passwd* pwd_result;
-	char* pwd_buf;
+	char* pwd_buf = NULL;
 	long int pwd_bufsize;
 	struct stat st;
 
@@ -322,6 +322,8 @@ bool write_ssh_keys(const GString* data, const gchar* username) {
 			LOG(MOD "Cannot change the owner and group of %s.\n", auth_keys_file);
 			return false;
 		}
+	} else {
+		free(pwd_buf);
 	}
 
 	return true;