Feature/ekf diagnostics #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilary-luo
requested review from
tonybaltovski and
mhosmar-cpr
and removed request for
a team
tonybaltovski
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ekf node diagnostic entry was showing up however it wasn't being used since the print_diagnostics parameter defaults to false. This PR sets the parameter true so we can see the diagnostic status.
To be most correct a PR could be made to not create the headerless topic diagnostic object if print_diagnostic is false but it isn't negatively impacting anything unless you want to use diagnostics without ekf_node.
Also added a missing
continuein the CI.