fix missing null return

cleoold · Mar 1, 2020 · 732aa14 · 732aa14
1 parent 3733112
commit 732aa14
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/lvbdist/__init__.py b/lvbdist/__init__.py
@@ -1,4 +1,4 @@
-__version__ = "1.0.1"
+__version__ = "1.0.2"
 
 from ._lvbdist import cmax_times as _cmax_times
 from ._lvbdist import chave_success_given_no_successes_before as _chave_success_given_no_successes_before

diff --git a/lvbdist/lvbdist_back.c b/lvbdist/lvbdist_back.c
@@ -67,13 +67,19 @@ LVBDIST_PROVIDE(have_m_successes_within_n_attempts_E) {
 
 LVBDIST_PROVIDE(have_special_success_within_n_attempts) {
     LVBDIST_SCAN_ARG_AND_DECLARE("id", int n;probability p, &n, &p);
-    if (p <= 0 || p >= 1) PyErr_SetString(PyExc_ValueError, "Invalid probability");
+    if (p <= 0 || p >= 1) {
+        PyErr_SetString(PyExc_ValueError, "Invalid probability");
+        return NULL;
+    }
     LVBDIST_RETURN(have_special_success_within_n_attempts, n, p);
 }
 
 LVBDIST_PROVIDE(have_special_success_within_n_attempts_E) {
     LVBDIST_SCAN_ARG_AND_DECLARE("d", probability p, &p);
-    if (p <= 0 || p >= 1) PyErr_SetString(PyExc_ValueError, "Invalid probability");
+    if (p <= 0 || p >= 1) {
+        PyErr_SetString(PyExc_ValueError, "Invalid probability");
+        return NULL;
+    }
     LVBDIST_RETURN(have_special_success_within_n_attempts_E, p);
 }
 

diff --git a/setup.py b/setup.py
@@ -13,7 +13,7 @@ def main():
     )
 
     setup(name="linearly-varying-binomial-distribution",
-          version="1.0.1",
+          version="1.0.2",
           description="computes ununiform step-increasing probability problems",
           long_description=long_description,
           long_description_content_type="text/markdown",