Skip to content

Add Vue SDK custom <UserProfile /> and <OrganizationProfile /> pages examples #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 18, 2025

Conversation

wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Feb 7, 2025

🔎 Previews:

What does this solve?

  • Since the implementation uses Vue slots (rather than props like in React) to pass in custom components, it's important to document this approach.

What changed?

  • Adds Vue examples to each section of the custom pages docs
  • Shows proper usage of template slots for custom components

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

Copy link

github-actions bot commented Feb 7, 2025

Hey, here’s your docs preview: https://clerk.com/docs/pr/2002

@wobsoriano wobsoriano marked this pull request as ready for review February 7, 2025 16:19
@wobsoriano wobsoriano requested a review from a team as a code owner February 7, 2025 16:19
@alexisintech
Copy link
Member

hey! I've updated the copy of both guides, and fixed some of the vue examples.
I've left some TODOs, there are some broken examples that I can't fix on my side - think it needs a source code fix

@wobsoriano
Copy link
Member Author

hey! I've updated the copy of both guides, and fixed some of the vue examples. I've left some TODOs, there are some broken examples that I can't fix on my side - think it needs a source code fix

Noted on this, thank you!

@wobsoriano
Copy link
Member Author

Hi @alexisintech! Fixed the issues in #5128 and #5129 and updated the Vue quickstart to use @clerk/[email protected] which includes the fix. Can you try it again? Thank you!

Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything's working!! 😸💖

@wobsoriano
Copy link
Member Author

everything's working!! 😸💖

awesomeee!

@wobsoriano wobsoriano merged commit 1264337 into main Feb 18, 2025
6 checks passed
@wobsoriano wobsoriano deleted the rob/eco-361-custom-pages branch February 18, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants