-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(expo/use-sso) Add redirectUrl
parameter to startSSOFlow
; remove expo partials
#2005
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ef80482
Add `redirectUrl` parameter to `startSSOFlow`
LauraBeatris fbf01cb
code review; pending testing
alexisintech fa5be26
Update `redirectUrl` reference to indicate default path
LauraBeatris 9ab193a
Update snippets to use `AuthSession.makeRedirectUri`
LauraBeatris dae3483
Apply suggestions from code review
alexisintech 6df3add
Apply suggestions from code review
alexisintech 0f0de67
Add comment to highlight current path
LauraBeatris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I don't see where the
/sso-callback
is used - users don't have to set anything up for this page, so if this/sso-callback
path is actually hit behind the scenes, is this even worth mentioning?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If deep linking is working - in this case, for Android since iOS currently has a bug from our tests so far (expo/expo#34187)
And
redirectUrl
is not defined, then we'll navigate tosso-callback
, and if they don't have this route configured on the app, it'll lead to a 404 - reason why I think it's worth mentioning the defaultThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused. The examples never set up a
/sso-callback
page. Whenever I tested, the flows just worked. There was never a 404.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On
useOAuth
, the default redirect URL used to beoauth-native-callback
- however it's not mentioned in the previous guide:https://github.com/clerk/javascript/blob/cab940862870e7961ba92e88ae3e6228b1893e97/packages/expo/src/hooks/useOAuth.ts#L59-L61
On
useSSO
, the default is now set tosso-callback
I recognize this is confusing... and this is the behavior for iOS in development mode, as I mentioned it could be a bug with Expo (expo/expo#34187) in which we haven't tried to reproduce on production iOS builds
When using
useSSO
on Android, the deep link does happen correctly if you provide a valid URL. The behavior can be found in this PR description: clerk/javascript#5102 (comment)