chore(clerk-js): Use local environment on outage #5420

panteliselef · 2025-03-21T20:31:10Z

Description

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

vercel · 2025-03-21T20:31:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
clerk-js-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2025 9:08pm

changeset-bot · 2025-03-21T20:31:14Z

🦋 Changeset detected

Latest commit: 9bad073

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/clerk-js/src/utils/localStorage.ts

jacekradko · 2025-03-25T03:23:04Z

packages/clerk-js/src/core/clerk.ts

+          .catch(e => {
+            const environmentSnapshot = SafeLocalStorage.getItem<EnvironmentJSONSnapshot | null>(
+              CLERK_ENVIRONMENT_STORAGE_ENTRY,
+              null,
+            );
+
+            if (!environmentSnapshot) {
+              throw e;
+            }
+
+            this.updateEnvironment(new Environment(environmentSnapshot));


I am wondering if this logic shouldn't be contained within the EnvironmentResource class. Seems like it could simplify the implementation overall

I am a bit confused here, are you advocating for this to be included in the Environment class because currently it is not.

If that is the case, I'd suggest doing this in another follow up PR, which will improve the overall architecture which would handle this for non-standard browsers (e.g. Expo).

@panteliselef Yes, I think having this logic be encapsulated in the EnvrionmentResource class would be preferrable. No issue with doing it as a follow up

…-locally # Conflicts: # packages/clerk-js/bundlewatch.config.json

panteliselef · 2025-03-26T20:17:47Z

!snapshot

clerk-cookie · 2025-03-26T20:19:59Z

Hey @panteliselef - the snapshot version command generated the following package versions:

Package	Version
@clerk/agent-toolkit	0.0.16-snapshot.v20250326201838
@clerk/astro	2.4.5-snapshot.v20250326201838
@clerk/backend	1.25.8-snapshot.v20250326201838
@clerk/chrome-extension	2.2.23-snapshot.v20250326201838
@clerk/clerk-js	5.58.1-snapshot.v20250326201838
@clerk/elements	0.23.8-snapshot.v20250326201838
@clerk/clerk-expo	2.9.6-snapshot.v20250326201838
@clerk/expo-passkeys	0.1.29-snapshot.v20250326201838
@clerk/express	1.3.59-snapshot.v20250326201838
@clerk/fastify	2.1.32-snapshot.v20250326201838
@clerk/localizations	3.13.4-snapshot.v20250326201838
@clerk/nextjs	6.12.12-snapshot.v20250326201838
@clerk/nuxt	1.4.6-snapshot.v20250326201838
@clerk/clerk-react	5.25.5-snapshot.v20250326201838
@clerk/react-router	1.1.11-snapshot.v20250326201838
@clerk/remix	4.5.11-snapshot.v20250326201838
@clerk/shared	3.2.3-snapshot.v20250326201838
@clerk/tanstack-react-start	0.12.2-snapshot.v20250326201838
@clerk/testing	1.4.33-snapshot.v20250326201838
@clerk/themes	2.2.26-snapshot.v20250326201838
@clerk/types	4.50.1-snapshot.v20250326201838
@clerk/vue	1.4.5-snapshot.v20250326201838

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/agent-toolkit

npm i @clerk/[email protected] --save-exact

@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/expo-passkeys

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/nuxt

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/react-router

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-react-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@clerk/vue

npm i @clerk/[email protected] --save-exact

chore(clerk-js): Use local environment on outage

95a4824

vercel bot deployed to Preview March 21, 2025 20:31 View deployment

clerk-cookie added the clerk-js label Mar 21, 2025

panteliselef self-assigned this Mar 21, 2025

use variable instead of string

dd6b7d2

vercel bot deployed to Preview March 21, 2025 20:34 View deployment

panteliselef added 2 commits March 21, 2025 22:56

minor change

91212b3

minor change

c1e8697

vercel bot deployed to Preview March 21, 2025 21:07 View deployment

fix lint

124c177

vercel bot deployed to Preview March 21, 2025 21:13 View deployment

jacekradko reviewed Mar 24, 2025

View reviewed changes

packages/clerk-js/src/utils/localStorage.ts Outdated Show resolved Hide resolved

jacekradko reviewed Mar 25, 2025

View reviewed changes

jacekradko approved these changes Mar 26, 2025

View reviewed changes

Merge branch 'refs/heads/main' into elef/sdki-955-persist-environment…

184ecc8

…-locally # Conflicts: # packages/clerk-js/bundlewatch.config.json

vercel bot deployed to Preview March 26, 2025 20:13 View deployment

update bundle watch

9bad073

vercel bot deployed to Preview March 26, 2025 20:18 View deployment

update logic

24c830d

vercel bot deployed to Preview March 26, 2025 21:08 View deployment

panteliselef merged commit 98286dc into main Mar 26, 2025
30 checks passed

panteliselef deleted the elef/sdki-955-persist-environment-locally branch March 26, 2025 21:44

clerk-cookie mentioned this pull request Mar 26, 2025

ci(repo): Version packages #5461

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(clerk-js): Use local environment on outage #5420

chore(clerk-js): Use local environment on outage #5420

panteliselef commented Mar 21, 2025

vercel bot commented Mar 21, 2025 •

edited

Loading

changeset-bot bot commented Mar 21, 2025 •

edited

Loading

jacekradko Mar 25, 2025 •

edited

Loading

panteliselef Mar 26, 2025

jacekradko Mar 26, 2025 •

edited

Loading

panteliselef commented Mar 26, 2025

clerk-cookie commented Mar 26, 2025

chore(clerk-js): Use local environment on outage #5420

chore(clerk-js): Use local environment on outage #5420

Conversation

panteliselef commented Mar 21, 2025

Description

Checklist

Type of change

vercel bot commented Mar 21, 2025 • edited Loading

changeset-bot bot commented Mar 21, 2025 • edited Loading

🦋 Changeset detected

jacekradko Mar 25, 2025 • edited Loading

Choose a reason for hiding this comment

panteliselef Mar 26, 2025

Choose a reason for hiding this comment

jacekradko Mar 26, 2025 • edited Loading

Choose a reason for hiding this comment

panteliselef commented Mar 26, 2025

clerk-cookie commented Mar 26, 2025

vercel bot commented Mar 21, 2025 •

edited

Loading

changeset-bot bot commented Mar 21, 2025 •

edited

Loading

jacekradko Mar 25, 2025 •

edited

Loading

jacekradko Mar 26, 2025 •

edited

Loading