-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(clerk-js,types): Load tasks based on environment settings #5422
Open
LauraBeatris
wants to merge
5
commits into
main
Choose a base branch
from
laura/lazy-load-tasks-env
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+174
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4dde647 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a20ae6a
to
e147a5f
Compare
e147a5f
to
a8a6526
Compare
ff45aea
to
336604a
Compare
336604a
to
8ffa4d7
Compare
8ffa4d7
to
dfe49ef
Compare
dfe49ef
to
fd9a6f0
Compare
fd9a6f0
to
2633070
Compare
2633070
to
b8abacc
Compare
b8abacc
to
25ca39e
Compare
25ca39e
to
9b5b6c0
Compare
9b5b6c0
to
d50c67c
Compare
d50c67c
to
7ced9f8
Compare
7ced9f8
to
7246270
Compare
9 tasks
Here are a few considerations when it comes to optimizations:
|
007b92b
to
898571f
Compare
898571f
to
0d13c03
Compare
0d13c03
to
79831ab
Compare
79831ab
to
4dde647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the previous
experimental.withSessionTasks
flag in favor of preloadingSessionTasks
component based on the current environment settings, to avoid downloading its chunk of JS for instances that aren't using this feature.Breakdown
Main changes:
/tasks
) so thatSessionTasks
can declare inner routes to be reused acrossSignIn/SignUp
SessionTasks
can now be used as standalone, outside ofSignIn/SignUp
paths, such as rendering it on a catchall (/onboarding/[[...index]].tsx
) -> coming in a next PR@clerk/backend
when the incoming JWT claims containsts
pending -> coming in a next PRMisc:
SessionTasks
on bundlewatch to track size across PRstasks
on plural, since that component can have multiple tasks routes / render multiple tasksChecklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change