Skip to content

[update] - add missing french fr-FR locales for the billing elements #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bde-maze
Copy link

@bde-maze bde-maze commented May 16, 2025

Description

As discussed with Joe from Support, I'm adding missing French locales, mostly to support the new and Beta Billing feature.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • [ x ] other:

Copy link

changeset-bot bot commented May 16, 2025

🦋 Changeset detected

Latest commit: a6b43f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@clerk/localizations Minor
@clerk/chrome-extension Minor
@clerk/clerk-js Minor
@clerk/clerk-expo Minor
@clerk/nextjs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 16, 2025

@bde-maze is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@alexcarpenter
Copy link
Member

@bde-maze thanks for the contribution. Can you add a changeset #5944 (comment) and we can get this merged in.

@bde-maze
Copy link
Author

@bde-maze thanks for the contribution. Can you add a changeset #5944 (comment) and we can get this merged in.

Hello Alex, thank you for pointing this out ! I've added the changeset - let me know if it's all good for you.

@@ -0,0 +1,5 @@
---
'@clerk/localizations': minor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@clerk/localizations': minor
'@clerk/localizations': patch

Since we are just adding new translations vs a new language, we can mark this as a patch.

Comment on lines +1 to +8
---
'@clerk/chrome-extension': minor
'@clerk/clerk-js': minor
'@clerk/clerk-expo': minor
'@clerk/nextjs': minor
---

Add missing French locales to support new Clerk's Billing feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changesets will automatically handle updating that packages that rely on the localizations, so we can remove this extra changeset here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants