Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow module to be directly required #1

Closed
wants to merge 1 commit into from
Closed

Allow module to be directly required #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module github.com/shurcooL/graphql
module github.com/cli/shurcooL-graphql
Copy link

@mislav mislav Nov 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By just doing this one-line change, is the cli/cli project that depends on this fork now immediately go-getable? Wouldn't we need to also replace every github.com/shurcooL/graphql import directive in this fork with ithub.com/cli/shurcooL-graphql?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so, yes. I did a quick code search and beyond the go.mod there only seem to be a few references:

That said, some of its other dependencies also refer to the same thing:

So perhaps such a change would not work without further forking that as well (however that module is even smaller than this one).

The political approach is to push for these:

I am not sure how long that would take though (especially since they both seem to have bogus failures in their CI).


go 1.13

Expand Down