Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cider--sesman-friendly-session-p: check for ns-list op availability #3488

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

vemv
Copy link
Member

@vemv vemv commented Sep 28, 2023

This speeds up (cider-current-repl) performance in non-linked buffers from to 0.01s to 0.0001s.

Because (cider-current-repl) can be repeatedly invoked by e.g. electric-indent-mode, the numbers make a difference.

No changelog is needed because the ns-list logic was introduced recently.

Fixes clojure-emacs/clojure-mode#665 (which mostly affects Babashka users, or users using bare nrepl without cider-nrepl)

Cheers - V

This speeds up `(cider-current-repl)` performance in non-linked buffers from to 0.01s to 0.00098800s.

Because `(cider-current-repl)` can be repeatedly invoked by e.g. `electric-indent-mode`, it makes a difference.

Fixes clojure-emacs/clojure-mode#665
@vemv vemv requested a review from bbatsov September 28, 2023 19:33
@bbatsov bbatsov merged commit bb1c477 into master Sep 29, 2023
@bbatsov bbatsov deleted the ns-list-check branch September 29, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation very slow on 20230911.1653
2 participants