Move four cljs-only items from cider.el to cider-cljs.el#3904
Merged
Conversation
Follow-up to the cider-cljs.el extraction. Pulls four small cljs-only forms out of cider.el so cider-cljs.el is the single home for cljs concerns: - cider-offer-to-open-cljs-app-in-browser - the toggle for the browser-opener that already lives here. - cider-connect-default-cljs-params - the cljs counterpart of cider-connect-default-params. - cider--update-cljs-type - tiny param updater that only touches cider-select-cljs-repl / cider-default-cljs-repl, both already here. - cider--with-cljs-jack-in-deps - macro that let-binds the cljs jack-in vars (defined in cider-jack-in.el) for the duration of jack-in-cljs flows. cider-cljs.el now requires cider-jack-in for the macro's references, and forward-declares cider--update-do-prompt (which stays in cider.el). cider.el drops 50 lines, cider-cljs.el gains 55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3903. Pulls four small cljs-only forms out of cider.el so cider-cljs.el is the single home for cljs concerns:
cider-offer-to-open-cljs-app-in-browser- toggle for the browser-opener that already lives in cider-cljs.el.cider-connect-default-cljs-params- the cljs counterpart ofcider-connect-default-params.cider--update-cljs-type- tiny param updater that only touchescider-select-cljs-repl/cider-default-cljs-repl, both already in cider-cljs.el.cider--with-cljs-jack-in-deps- macro that let-binds the cljs jack-in vars (which now live in cider-jack-in.el) for the duration of jack-in-cljs flows.cider-cljs.el now requires
cider-jack-infor the macro's references, and forward-declarescider--update-do-prompt(which stays in cider.el). 50 lines out of cider.el, 55 into cider-cljs.el.eldev compile --warnings-as-errorseldev test)