Move universal jack-in + project-type detection to cider-jack-in.el#3907
Merged
Conversation
cider-jack-in-universal is the obvious peer to cider-jack-in-clj/cljs, all of which already live in cider-jack-in.el; pulling these final bits in completes the jack-in subsystem. Moved: - cider--identify-buildtools-present and cider-project-type - project type detection that walks cider-jack-in-tools (already in this file) - cider--effective-jack-in-default - auto-detect helper for the default tool when cider-jack-in-default is nil - cider--universal-jack-in-tools, cider--universal-jack-in-opts, and cider-jack-in-universal - the dispatcher driven by :universal-prefix-arg cider-jack-in.el forward-declares cider-preferred-build-tool and cider-jack-in-default (still defcustoms in cider.el). The ;;;###autoload cookie on cider-jack-in-universal is preserved. cider.el drops from 1181 to 1070 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls the last clearly-jack-in bits out of cider.el.
cider-jack-in-universalis the obvious peer tocider-jack-in-clj/cljs, which already live in cider-jack-in.el; this completes the jack-in subsystem extraction.Moved:
cider--identify-buildtools-presentandcider-project-type— project-type detection that walkscider-jack-in-tools.cider--effective-jack-in-default— auto-detect helper for the default tool whencider-jack-in-defaultis nil.cider--universal-jack-in-tools,cider--universal-jack-in-opts, andcider-jack-in-universal— the dispatcher driven by:universal-prefix-arg.cider-jack-in.el forward-declares
cider-preferred-build-toolandcider-jack-in-default(still defcustoms in cider.el). The;;;###autoloadcookie oncider-jack-in-universalis preserved.cider.el: 1181 → 1070 lines.
eldev compile --warnings-as-errorseldev test)