Consolidate jack-in defcustoms into cider-jack-in.el#3910
Merged
Conversation
cider.el's customization section still held all the jack-in-only defcustoms: per-tool command/parameter pairs and the cross-tool jack-in toggles. Move them next to the code that actually uses them. Moved (~17 defcustoms): - Per-tool command/parameter pairs for lein, clojure-cli (incl. aliases / global-aliases), shadow-cljs, gradle, babashka, nbb, and basilisp. - Cross-tool toggles: cider-jack-in-default, cider-preferred-build-tool, cider-allow-jack-in-without-project, cider-inject-dependencies-at-jack-in, cider-enable-nrepl-jvmti-agent. Each gets `:group 'cider' since the defgroup stays in cider.el, but the in-Customize grouping is unchanged for users. Removing the now-redundant `(defvar ...)` forward declarations from cider-jack-in.el's prologue is the second half of the diff. cider.el's customization section is now ~50 lines of project metadata, connect hooks, and `cider-version`; jack-in's user-tunable knobs all live with the jack-in code. cider.el drops from 773 to 577 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cider.el's customization section still held all the jack-in-only defcustoms: per-tool command/parameter pairs and the cross-tool jack-in toggles. Move them next to the code that actually uses them.
Moved (~17 defcustoms):
cider-jack-in-default,cider-preferred-build-tool,cider-allow-jack-in-without-project,cider-inject-dependencies-at-jack-in,cider-enable-nrepl-jvmti-agent.Each gets
:group 'cidersince the defgroup stays in cider.el, but the in-Customize grouping is unchanged for users. The now-redundant(defvar ...)forward declarations get removed from cider-jack-in.el's prologue.cider.el's customization section is now just project metadata, connect hooks, and
cider-version; jack-in's user-tunable knobs all live with the jack-in code.cider.el: 773 → 577 lines.
eldev compile --warnings-as-errorseldev test)